christian/session-mcp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(CF-306): Validate session_id in memory_add to prevent FK violations

Browse Source 
Added validation to check if session_id exists in sessions table before
inserting memories. Falls back to NULL if session not found, preventing
foreign key constraint violations while preserving memory content.

Logs warning when invalid session_id provided for debugging.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This commit is contained in:
Christian Gick
2026-01-20 10:17:53 +02:00
parent 18a016f82f
commit 2439d4a645
1 changed files with 16 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/tools/memories.ts
View File

@@ -43,10 +43,24 @@ interface MemoryListArgs {
/** /**
* Add a new memory/learning (enhanced with session_id and task_id) * Add a new memory/learning (enhanced with session_id and task_id)
* CF-306: Validates session_id exists before inserting to prevent foreign key violations
*/ */
export async function memoryAdd(args: MemoryAddArgs): Promise<string> { export async function memoryAdd(args: MemoryAddArgs): Promise<string> {
const { category, title, content, context, project, session_id, task_id } = args; const { category, title, content, context, project, session_id, task_id } = args;
// CF-306: Validate session_id exists if provided
let validSessionId = session_id || null;
if (session_id) {
const sessionExists = await queryOne<{ exists: boolean }>(
`SELECT EXISTS(SELECT 1 FROM sessions WHERE id = $1) as exists`,
[session_id]
);
if (!sessionExists?.exists) {
console.warn(`[CF-306] Session ${session_id} not found in database - using NULL instead`);
validSessionId = null;
}
}
// Generate embedding for semantic search // Generate embedding for semantic search
const embedText = `${title}. ${content}`; const embedText = `${title}. ${content}`;
const embedding = await getEmbedding(embedText); const embedding = await getEmbedding(embedText);
@@ -56,13 +70,13 @@ export async function memoryAdd(args: MemoryAddArgs): Promise<string> {
await execute( await execute(
`INSERT INTO memories (category, title, content, context, project, session_id, task_id, embedding) `INSERT INTO memories (category, title, content, context, project, session_id, task_id, embedding)
VALUES ($1, $2, $3, $4, $5, $6, $7, $8)`, VALUES ($1, $2, $3, $4, $5, $6, $7, $8)`,
[category, title, content, context || null, project || null, session_id || null, task_id || null, embeddingValue] [category, title, content, context || null, project || null, validSessionId, task_id || null, embeddingValue]
); );
} else { } else {
await execute( await execute(
`INSERT INTO memories (category, title, content, context, project, session_id, task_id) `INSERT INTO memories (category, title, content, context, project, session_id, task_id)
VALUES ($1, $2, $3, $4, $5, $6, $7)`, VALUES ($1, $2, $3, $4, $5, $6, $7)`,
[category, title, content, context || null, project || null, session_id || null, task_id || null] [category, title, content, context || null, project || null, validSessionId, task_id || null]
); );
} }